Skip to content

fix 0.11.1 replay against NAP opendbc - #29

Closed
daggerhashjack wants to merge 1 commit into
nap-devfrom
fix/process-replay-opendbc-flags
Closed

daggerhashjack wants to merge 1 commit into
nap-devfrom
fix/process-replay-opendbc-flags

Conversation

@daggerhashjack

Copy link
Copy Markdown

Process replay was crashing on every shard because 0.11.1 migration uses HyundaiSafetyFlags.CANFD_LKA_STEER_MSG and NAP opendbc still names that bit CANFD_LKA_STEERING.

hyundai/selfdrived now matches the current refs. dmonitoringd and locationd still differ from the pre-0.11.1 refs, which is expected after the version take. After this lands, run the hosted process-replay ref generator on nap-dev.

Also: macOS scons looks up openssl without brew on PATH, unit tests build libsafety.so, and tools/sim is ignored because this opendbc does not ship comma's generated honda DBCs.

comma's migration uses HyundaiSafetyFlags.CANFD_LKA_STEER_MSG.
NAP opendbc still names that bit CANFD_LKA_STEERING, so every
process-replay case crashed before compare. Find macOS openssl
without brew on PATH, build libsafety for unit tests, and skip
tools/sim which needs honda generated DBCs this tree does not ship.
@daggerhashjack
daggerhashjack requested a review from SloPOS as a code owner August 29, 2026 17:13
@daggerhashjack

Copy link
Copy Markdown
Author

Superseded by #30 on nap-dev.

@daggerhashjack
daggerhashjack deleted the fix/process-replay-opendbc-flags branch September 3, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant