Repository navigation
fix 0.11.1 replay against NAP opendbc - #29
Closed
daggerhashjack wants to merge 1 commit into
Closed
daggerhashjack wants to merge 1 commit into
daggerhashjack wants to merge 1 commit into
Conversation
comma's migration uses HyundaiSafetyFlags.CANFD_LKA_STEER_MSG. NAP opendbc still names that bit CANFD_LKA_STEERING, so every process-replay case crashed before compare. Find macOS openssl without brew on PATH, build libsafety for unit tests, and skip tools/sim which needs honda generated DBCs this tree does not ship.
Author
|
Superseded by #30 on nap-dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process replay was crashing on every shard because 0.11.1 migration uses HyundaiSafetyFlags.CANFD_LKA_STEER_MSG and NAP opendbc still names that bit CANFD_LKA_STEERING.
hyundai/selfdrived now matches the current refs. dmonitoringd and locationd still differ from the pre-0.11.1 refs, which is expected after the version take. After this lands, run the hosted process-replay ref generator on nap-dev.
Also: macOS scons looks up openssl without brew on PATH, unit tests build libsafety.so, and tools/sim is ignored because this opendbc does not ship comma's generated honda DBCs.